Add ValkeySearch commands

[eric-musliner]

This is dependent on the work to update the command json files in the ValkeySearch project valkey-io/valkey-search#504

[codecov-commenter]

Codecov Report

❌ Patch coverage is 98.59649% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@b813e95). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
Sources/ValkeySearch/SearchCommands.swift	98.59%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage        ?   42.38%           
=======================================
  Files           ?       98           
  Lines           ?    12581           
  Branches        ?        0           
=======================================
  Hits            ?     5333           
  Misses          ?     7248           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[adam-fowler]

It's great you've added the updates to the spec files. I believe this'll also improve the documentation. I can't really merge this PR until the spec files PR is merged (and ideally in a release). We are near releasing a 1.0 and that will mean breaking changes can't be merged. We can workaround changes to the API caused by changes to the json spec files, but I don't really want to be doing this multiple times. We could hide these behind an "experimental-json-search" trait which we document as an API that may change.

[eric-musliner]

It's great you've added the updates to the spec files. I believe this'll also improve the documentation. I can't really merge this PR until the spec files PR is merged (and ideally in a release). We are near releasing a 1.0 and that will mean breaking changes can't be merged. We can workaround changes to the API caused by changes to the json spec files, but I don't really want to be doing this multiple times. We could hide these behind an "experimental-json-search" trait which we document as an API that may change.

Completely understand. This PR is dependent on the JSON changes getting approved and merged in ValkeySearch. I definitely want eyes on that one to make sure it's correct and that I'm not missing anything.

[eric-musliner]

Updated again for ft.aggregate changes

[adam-fowler]

I'm wondering if we can release this behind a ExperimentalValkeySearch trait. I've been bitten using traits with Hummingbird so uncertain about this.

[eric-musliner]

I'm wondering if we can release this behind a ExperimentalValkeySearch trait. I've been bitten using traits with Hummingbird so uncertain about this.

I've never used traits before, but the valkey search commands don't break the existing APIs so even if you do put out a 1.0.0 release before this gets merged in you could include the valkey search commands in a minor version update? Unless you're rationale is to bring it in as a trait since now since we are still waiting on confirmation about json docs?

[adam-fowler]

The rationale of adding it behind a trait tagged experimental is we are not committing to the public API. So if there is an error in the generated code we don't have to worry about breaking changes.

[eric-musliner]

The rationale of adding it behind a trait tagged experimental is we are not committing to the public API. So if there is an error in the generated code we don't have to worry about breaking changes.

That makes sense to me if you want to bring it in before the json documents are reviewed and merged.