Skip to content

Fix sensor spike handling and improve PID output stabilization#5

Open
rkimbers wants to merge 2 commits intovalkjsaaa:mainfrom
rkimbers:fix-inconsistency-check
Open

Fix sensor spike handling and improve PID output stabilization#5
rkimbers wants to merge 2 commits intovalkjsaaa:mainfrom
rkimbers:fix-inconsistency-check

Conversation

@rkimbers
Copy link

Changes Made

  • Introduced a tolerance adjustment for handling sensor spikes to prevent frequent resets to automatic mode.
  • Added constraints to the PID controller to ensure output remains within the specified limits.
  • A few logging changes for the PID parameters and outputs.

Issue Addressed

  • Hardcoded threshold for inconsistent sensor values was causing frequent spikes in fan speed (these would wake me up in the middle of the night) when sensor data briefly fluctuated.

This change SHOULD not affect other functionalities but significantly reduces noise and enhances fan control stability. I ran this script on my T640 and it was fine under load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant