Skip to content

Conversation

@SLMT
Copy link
Member

@SLMT SLMT commented Apr 19, 2022

This PR updates the design of parameter helpers so that we can use the helpers in both JDBC and stored procedures. Before merging this PR, the reviewers must first ensure that the corresponding changes in VanillaCore is merged.

Here are the major changes in this PR:

  • A parameter helper is now separated into two classes. One is for dealing with unpacking parameters, and another is for dealing with the result sets of stored procedures. The later one extends the former one in order to reuse the code. Now we call the former one a parameter helper and the later one a stored procedure helper (SpHelper).
  • All parameter helpers are now put in org.vanilladb.bench.benchmarks.xxx.rte packages
  • All sp helpers are now put in org.vanilladb.bench.server.procedure.xxx packages
  • All variables are renamed to reflect the above changes.

@SLMT SLMT requested a review from xuan19970825 April 19, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants