Rename SQLRaw to SQLUnsafeRaw and SQLRawBuilder to SQLUnsafeRawBuilder#189
Closed
Rename SQLRaw to SQLUnsafeRaw and SQLRawBuilder to SQLUnsafeRawBuilder#189
Conversation
…tabase.unsafeRaw(_:)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 2662 2664 +2
=========================================
+ Hits 2662 2664 +2
🚀 New features to boost your workflow:
|
0xTim
approved these changes
Apr 17, 2025
Member
0xTim
left a comment
0xTim
left a comment
There was a problem hiding this comment.
I have to say, something about this does feel off - essential all the unsafe usages inside our codebase. I know it's a semantic thing and I don't really have a good answer other than adding internal functions for our own use. But I don't think it's an issue or a blocker, just something I noticed. (Also came up when thinking about other libraries such as FluentPostGIS - I guess we need to be able to opt into the unsafe things so this is probably the best way)
ptoffy
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We really want to emphasize as much as possible that using raw SQL is unsafe. These changes also match up with the same renames in the Fluent 5 version of SQLKit. The original
SQLRawandSQLRawBuildernames are preserved as a deprecatedtypealias, as is the originalSQLDatabase.raw(_:)spelling of what is now theSQLDatabase.unsafeRaw(_:)method.