Skip to content

package: Drop setuptools_scm_git_archive requirement#52

Merged
haraldh merged 1 commit intovarlink:masterfrom
omrisarig13:omsa/remove-setuptools-scm-git-archive
Mar 17, 2025
Merged

package: Drop setuptools_scm_git_archive requirement#52
haraldh merged 1 commit intovarlink:masterfrom
omrisarig13:omsa/remove-setuptools-scm-git-archive

Conversation

@omrisarig13
Copy link
Contributor

The tool of setuptools_scm_git_archive is deprecated. The logic of this package was introduced directly to the setuptools_scm package, since version 7.0.0 of this package.

This commit removes the unnecessary requirement to have setuptools_scm_git_archive, and instead, ensures that the setuptools_scm version used is recent enough.

The tool of setuptools_scm_git_archive is deprecated. The logic of this
package was introduced directly to the setuptools_scm package, since
version 7.0.0 of this package.

This commit removes the unnecessary requirement to have
setuptools_scm_git_archive, and instead, ensures that the setuptools_scm
version used is recent enough.
Copy link
Collaborator

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked up what packages varlink and so far it is Debian & Fedora and I have worked on an Arch Linux package where I simply drop the requirement for setuptools_scm_git_archive.

Interestingly neither Debian or Fedora depend on git_archive either and both provide a recent enough version of setuptools_scm (7.1 on Debian, 8 on Fedora). So I'm fine with dropping this. Although I have yet to understand what setuptools_scm offers and if it should be kept but that's something for a follow up.

For reference, the packaging links:
https://salsa.debian.org/python-team/packages/python-varlink/-/blob/debian/sid/debian/control?ref_type=heads#L11
https://src.fedoraproject.org/rpms/python-varlink/blob/rawhide/f/python-varlink.spec

@haraldh haraldh merged commit 2b30704 into varlink:master Mar 17, 2025
8 checks passed
@haraldh
Copy link
Contributor

haraldh commented Mar 17, 2025

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants