Skip to content

Drop Python 2 support in the spec file#53

Merged
behrmann merged 1 commit intovarlink:masterfrom
jelly:rpm-python3
Apr 12, 2025
Merged

Drop Python 2 support in the spec file#53
behrmann merged 1 commit intovarlink:masterfrom
jelly:rpm-python3

Conversation

@jelly
Copy link
Collaborator

@jelly jelly commented Apr 11, 2025

Python 2 support was already dropped in b9aa56d.


Did a local test mockbuild which succeeded, there is a question if this spec file should stay in the repository as it uses the second last release (30.3.1) instead of 31.0.0 which is the latest release and there is no automatic machinery to bump it.

What might be interesting is to switch to packit so on tag/release a pull request is send to pagure to automatically bump the package in Fedora.

Python 2 support was already dropped in b9aa56d.
@jelly jelly requested a review from behrmann April 11, 2025 14:31
Copy link
Collaborator

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really conversant in specfile, but from what I think I understand this looks good to me.

@behrmann
Copy link
Collaborator

Did a local test mockbuild which succeeded, there is a question if this spec file should stay in the repository as it uses the second last release (30.3.1) instead of 31.0.0 which is the latest release and there is no automatic machinery to bump it.

What might be interesting is to switch to packit so on tag/release a pull request is send to pagure to automatically bump the package in Fedora.

I have to admit, I have almost no idea what any of that means, but generally I'm in favour of consolidating this in one place, i.e. since the Fedora spec file lives in pagure and that probably powers CentOS and the whole RHEL family, there is little point in the spec file being here as well and this is much better handled there.

@behrmann behrmann merged commit 2f3151f into varlink:master Apr 12, 2025
8 checks passed
@jelly jelly deleted the rpm-python3 branch April 14, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants