Assorted cleanup and a few type hints#56
Merged
jelly merged 6 commits intovarlink:masterfrom Apr 23, 2025
Merged
Conversation
In the two places hasattr is not defined and will fall back to the function hasattr, which in the boolean context will be truthy and can therefore be exchanged for an else-clause.
jelly
approved these changes
Apr 22, 2025
Collaborator
|
Can we also already run mypy in CI with these changes? |
Collaborator
Author
|
Yes. It's not very useful at the moment, but I'll add it. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enough type hints to not make mypy run away in its stock config.