CI: Convert tox config to pyproject.toml, update tox envs#60
Merged
behrmann merged 8 commits intovarlink:masterfrom Jun 3, 2025
Merged
CI: Convert tox config to pyproject.toml, update tox envs#60behrmann merged 8 commits intovarlink:masterfrom
behrmann merged 8 commits intovarlink:masterfrom
Conversation
jelly
reviewed
May 27, 2025
jelly
requested changes
May 27, 2025
Collaborator
jelly
left a comment
jelly
left a comment
There was a problem hiding this comment.
Thanks, this looks interesting. Needs a small fixup
phlogistonjohn
force-pushed
the
jjm-checks
branch
from
95d55b1 to
0ae4828
Compare
The pep8 job was not running pep8 and instead is just a repeat of the py3 environment. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Add tox configuration to pyproject.toml matching the original configuration in tox.ini minus the pep8 entry in the envlist. This entry did not run pep8 and was thus misleading and not worth bringing over to the new configuration. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Remove tox.ini in favor of the tox configuration in pyproject.toml. This requires tox >= 4.21.0 (from Oct. 2024). Signed-off-by: John Mulligan <jmulligan@redhat.com>
Fixes: varlink#42 Switch to using pytest instead of nose2. Test coverage is done with pytest-cov. Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-checks
branch
from
0ae4828 to
72b76d4
Compare
jelly
approved these changes
May 31, 2025
behrmann
reviewed
May 31, 2025
phlogistonjohn
force-pushed
the
jjm-checks
branch
from
72b76d4 to
3a376c7
Compare
behrmann
reviewed
Jun 2, 2025
.github/workflows/main.yml
Outdated
| run: | | ||
| python3 -m mypy --version | ||
| python3 -m mypy varlink/ | ||
| tox -e py3-mypy |
Collaborator
There was a problem hiding this comment.
I'm really not a tox expert, but sine neither of the ruff tox envs have the py3- prefix, is it necessary here?
Contributor
Author
There was a problem hiding this comment.
No, it's not needed especially if you don't want tox choosing a python version for the env. I can remove that.
behrmann
reviewed
Jun 2, 2025
Add ruff and mypy test envs for tox to pyproject.toml. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Add a mypy configuration block to the pyproject.toml file that configures mypy to use python 3.9 syntax, the oldest version of python that the library supports. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Use tox as a wrapper around the ruff checks so that it is easier to run the same checks locally and in the ci. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Convert workflow file to use tox to run mypy. Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-checks
branch
from
3a376c7 to
0b006c6
Compare
behrmann
approved these changes
Jun 3, 2025
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started as a side discussion in #59 because I forgot to run all the ruff commands before pushing. :-)
This updates the tox configuration to:
The overall aim here is to ensure that the local user can run tests and checks outside of the CI environment without a lot of messing around.
Fixes: #42