Remove keyword argument to getattr#63
Merged
behrmann merged 2 commits intovarlink:masterfrom Jun 24, 2025
Merged
Conversation
getattr doesn't support keyword arguments for recent python versions at least.
```
for p in 3.10 3.11 3.12 3.13 3.14; do echo "Python $p"; uv run --python $p test.py; echo; done
Python 3.10
Traceback (most recent call last):
File "/home/kunalb/rough/2025/06/20/test.py", line 1, in <module>
getattr(1, 'a', default=None)
TypeError: getattr() takes no keyword arguments
Python 3.11
Traceback (most recent call last):
File "/home/kunalb/rough/2025/06/20/test.py", line 1, in <module>
getattr(1, 'a', default=None)
TypeError: getattr() takes no keyword arguments
Python 3.12
Traceback (most recent call last):
File "/home/kunalb/rough/2025/06/20/test.py", line 1, in <module>
getattr(1, 'a', default=None)
TypeError: getattr() takes no keyword arguments
Python 3.13
Traceback (most recent call last):
File "/home/kunalb/rough/2025/06/20/test.py", line 1, in <module>
getattr(1, 'a', default=None)
~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
TypeError: getattr() takes no keyword arguments
Python 3.14
Traceback (most recent call last):
File "/home/kunalb/rough/2025/06/20/test.py", line 1, in <module>
getattr(1, 'a', default=None)
~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
TypeError: getattr() takes no keyword arguments
```
behrmann
approved these changes
Jun 21, 2025
Collaborator
behrmann
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Would you mind running ruff format over this?
jelly
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getattr doesn't support keyword arguments for recent python versions at least; I was trying to use the server and would constantly encounter this error:
Just to make sure it wasn't anything custom: