Improve loading of base (org.varlink.service.varlink) interface description.#68
Merged
behrmann merged 1 commit intovarlink:masterfrom Sep 16, 2025
Merged
Conversation
behrmann
reviewed
Aug 1, 2025
Mocramis
force-pushed
the
better_base_iface_load
branch
from
52323cb to
9043a51
Compare
behrmann
reviewed
Aug 1, 2025
Mocramis
force-pushed
the
better_base_iface_load
branch
from
9043a51 to
bf25e70
Compare
behrmann
reviewed
Aug 5, 2025
Collaborator
behrmann
left a comment
behrmann
left a comment
There was a problem hiding this comment.
Apart from the ruff complaint LGTM.
Mocramis
force-pushed
the
better_base_iface_load
branch
from
bf25e70 to
fc1fba0
Compare
Author
|
Anything missing ? |
This will prevent issues with packed packages. Available since py39 and f080d4b dropped support of older versions.
Mocramis
force-pushed
the
better_base_iface_load
branch
from
fc1fba0 to
791cda7
Compare
Collaborator
|
I'll have a look why the ruff lint is broken now. |
Author
Thanks, it works locally though :/ |
Collaborator
Was fixed in #70, so this needs a rebase now (retried running the failed check but it failed again) |
behrmann
approved these changes
Sep 16, 2025
jelly
approved these changes
Sep 16, 2025
Collaborator
|
Merging, since I checked locally that ruff checks pass (with ruff 0.13). |
Author
|
Do you think a release with this fix could be possible (the last one being 2021 ). I can reapply the patch locally, but would be simpler to track an official version. |
Collaborator
Author
|
thank you for tatking the time to answer ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
varlink/org.varlink.service.varlinkwas loaded a lot when spawning temporary clients.I also had an issue when updating the package while some program was still running on the old version (although this doesn't fully solve this non-issue (in-place package updating is bad practice) as we can still instantiate the fist client while the package is being replaced).
The first commit is just an improvement opportunity i saw.