Fully switch to pyproject.toml and remove setup.cfg and setup.py#71
Merged
behrmann merged 4 commits intovarlink:masterfrom Sep 16, 2025
Merged
Fully switch to pyproject.toml and remove setup.cfg and setup.py#71behrmann merged 4 commits intovarlink:masterfrom
behrmann merged 4 commits intovarlink:masterfrom
Conversation
The option zip_safe is dropped is dropped, since it is considered obselete by setuptools and no longer supposed to do anything [1]. The option bdist_wheel.universal is dropped as well, since this flag used to show that a wheel was compatible with both Python 2 and 3 [2] and support for Python 2 has been dropped. More project urls are added, since pyproject.toml uses a richer section there instead of the previous single url field. The license classifier is switched to the SPDX identifier for the Apache 2.0 license and a license-files array linking to the respective file is added. The license classifier is removed, because at least some build backends refuse to build the package with both it and other license metadata at the same time in the file. [1] https://setuptools.pypa.io/en/latest/deprecated/zip_safe.html [2] https://wheel.readthedocs.io/en/stable/quickstart.html debug
Since setup.py and setup.cfg have been removed, the pin should no longer be necessary. This reverts commit 53a25fb.
Accoring to [1]
[…] More precisely, the following files are included in a source
distribution by default:
[…]
- All files specified by the license-files configuration parameter in
pyproject.toml and/or equivalent in setup.cfg/setup.py; note that if you
don’t explicitly set this parameter, setuptools will include any files that
match the following glob patterns: LICEN[CS]E*, COPYING*, NOTICE*,
AUTHORS**;
- README, README.txt, README.rst or README.md;
[…]
Rendering this file unnecessary.
[1] https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html
jelly
approved these changes
Sep 16, 2025
Collaborator
jelly
left a comment
jelly
left a comment
There was a problem hiding this comment.
Thanks! 🧹
Successfully build an Arch Linux package with your changes and there are only minor changes in the METADATA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've checked with a venv on master and this branch that the version comes out the same (modulo extra commits on this branch). I've also checked with diffoscope that the same files are included (specifically all .varlink files) and the only difference I saw were in timestamps.
Further explanation of the changes are in the message of the first commit.