Merged
Conversation
c875f2c to
9e1a40f
Compare
Collaborator
Author
I'll take a look tomorrow. |
9e1a40f to
444c0d3
Compare
Collaborator
Author
pytest is missing in the venv tox makes for mypy its a bit ugly to add it but it uglyier to ignore the import warning in pyproject.toml |
behrmann
reviewed
Oct 9, 2025
Test some uncovered error scenarios.
444c0d3 to
75d7689
Compare
9909867 to
c61c705
Compare
jelly
commented
Oct 13, 2025
Collaborator
Author
jelly
left a comment
There was a problem hiding this comment.
Next on my list is probably test_server_encoding.py which will then introduce a fixture for the ThreadingServer
behrmann
reviewed
Oct 14, 2025
Collaborator
behrmann
left a comment
There was a problem hiding this comment.
Forgot to hit send on this one.
c61c705 to
51eec57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.