Skip to content

Pytestify test scanner#78

Merged
behrmann merged 3 commits intovarlink:masterfrom
jelly:pytestify-test-scanner
Oct 15, 2025
Merged

Pytestify test scanner#78
behrmann merged 3 commits intovarlink:masterfrom
jelly:pytestify-test-scanner

Conversation

@jelly
Copy link
Collaborator

@jelly jelly commented Oct 8, 2025

No description provided.

@jelly jelly requested a review from behrmann October 8, 2025 20:27
@jelly jelly force-pushed the pytestify-test-scanner branch from c875f2c to 9e1a40f Compare October 8, 2025 20:28
@jelly
Copy link
Collaborator Author

jelly commented Oct 8, 2025

varlink/tests/test_scanner.py:1: error: Cannot find implementation or library stub for module named "pytest"  [import-not-found]
varlink/tests/test_scanner.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 14 source files)

I'll take a look tomorrow.

@jelly jelly force-pushed the pytestify-test-scanner branch from 9e1a40f to 444c0d3 Compare October 9, 2025 07:33
@jelly
Copy link
Collaborator Author

jelly commented Oct 9, 2025

varlink/tests/test_scanner.py:1: error: Cannot find implementation or library stub for module named "pytest"  [import-not-found]
varlink/tests/test_scanner.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 14 source files)

I'll take a look tomorrow.

pytest is missing in the venv tox makes for mypy its a bit ugly to add it but it uglyier to ignore the import warning in pyproject.toml

@jelly jelly force-pushed the pytestify-test-scanner branch from 444c0d3 to 75d7689 Compare October 9, 2025 10:39
@jelly jelly requested a review from behrmann October 9, 2025 10:39
Copy link
Collaborator

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jelly jelly force-pushed the pytestify-test-scanner branch from 9909867 to c61c705 Compare October 13, 2025 08:52
Copy link
Collaborator Author

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next on my list is probably test_server_encoding.py which will then introduce a fixture for the ThreadingServer

Copy link
Collaborator

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to hit send on this one.

@jelly jelly force-pushed the pytestify-test-scanner branch from c61c705 to 51eec57 Compare October 14, 2025 16:18
@behrmann behrmann merged commit b302a07 into varlink:master Oct 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants