remove composer.lock, tweak signature for php8.4 compatibility#47
Open
tacman wants to merge 1 commit intovarsitynewsnetwork:masterfrom
Open
remove composer.lock, tweak signature for php8.4 compatibility#47tacman wants to merge 1 commit intovarsitynewsnetwork:masterfrom
tacman wants to merge 1 commit intovarsitynewsnetwork:masterfrom
Conversation
Author
|
Could you accept this PR please?
|
Author
|
Friendly ping... No downside to approving this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer.lock should only be in applications, not libraries. Removing it allows tests to run under php 8.3 and 8.4, otherwise it's locked in to 8.2.
I changed the signature since implicit nullables are no longer allowed in php 8.4