671b9 #2256
Merged
671b9 #2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dist/extensionsVersions.xml
…o new HASL tab. Also fixed Chinese MMG B#, and updating to beta 9.
#2229: SaF:M Counters?
#2234 Missing beta 8 counters
Update branch
Issue1702 and bd08 fix
#2240 Bridge LOS fix
#2243 update bdBDF
#2246 update bd 39 & 47
Synch with develop
#2246 update bd 39
#1589 BoardZoomer add new factor
Contributor
Author
|
I have created the PR for the final 671 beta, beta9 which I would plan to release on Monday, Nov 3. Aside from Gordon's continued work on counter issues, the main changes are to the los code. While there are still bugs in the actual los calculations, this version should enable los in any crop / flip configuration (with los enabled boards). @GordonMolek you still have some commits in your branches that have not been pushed to develop. If you want these included, please let me know. |
Contributor
|
Yes, please include them or I can do so. I just didn't want to risk
conflicting with anything you were doing.
…On Sat, Nov 1, 2025 at 9:14 AM Doug Rimmer ***@***.***> wrote:
*derimmer* left a comment (vasl-developers/vasl#2256)
<#2256 (comment)>
I have created the PR for the final 671 beta, beta9 which I would plan to
release on Monday, Nov 3. Aside from Gordon's continued work on counter
issues, the main changes are to the los code. While there are still bugs in
the actual los calculations, this version should enable los in any crop /
flip configuration (with los enabled boards).
@GordonMolek <https://github.com/GordonMolek> you still have some commits
in your branches that have not been pushed to develop. If you want these
included, please let me know.
—
Reply to this email directly, view it on GitHub
<#2256 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYLTFUXOXUEV3UCPK7UIWRD32S53RAVCNFSM6AAAAACK3JY4SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZWGQYDQMBZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…ubstring Feature/text info red substring
Contributor
Author
|
Hi Gordon
I have successfully pulled the changes from feature/text-info-red-substring into develop. No issues.
However, when I try to pull changes from Gordon into develop, I get two conflicts, one with release-notes.md. Don't worry about that, I can sort it. The other is a buildFile conflict. Can you have a look and see if you can figure out what is going on. It appears that it might be a repeat of the first PR?
Doug
________________________________
From: GordonMolek ***@***.***>
Sent: Saturday, November 1, 2025 10:51 AM
To: vasl-developers/vasl ***@***.***>
Cc: Doug Rimmer ***@***.***>; Author ***@***.***>
Subject: Re: [vasl-developers/vasl] 671b9 (PR #2256)
[https://avatars.githubusercontent.com/u/102183634?s=20&v=4]GordonMolek left a comment (vasl-developers/vasl#2256)<#2256 (comment)>
Yes, please include them or I can do so. I just didn't want to risk
conflicting with anything you were doing.
On Sat, Nov 1, 2025 at 9:14 AM Doug Rimmer ***@***.***> wrote:
*derimmer* left a comment (vasl-developers/vasl#2256)
<#2256 (comment)>
I have created the PR for the final 671 beta, beta9 which I would plan to
release on Monday, Nov 3. Aside from Gordon's continued work on counter
issues, the main changes are to the los code. While there are still bugs in
the actual los calculations, this version should enable los in any crop /
flip configuration (with los enabled boards).
@GordonMolek <https://github.com/GordonMolek> you still have some commits
in your branches that have not been pushed to develop. If you want these
included, please let me know.
—
Reply to this email directly, view it on GitHub
<#2256 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYLTFUXOXUEV3UCPK7UIWRD32S53RAVCNFSM6AAAAACK3JY4SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZWGQYDQMBZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub<#2256 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB2W6IORWNA47RPFTPYVQ6T32TCH7AVCNFSM6AAAAACK3JY4SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZWGQZTIMRVGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
|
Doug,
Will do. Just to be clear, if I update my both my develop and gordon local
environments I should be able to compare the differences between the 2
branches, right?
Gordon
…On Sun, Nov 2, 2025 at 1:45 PM Doug Rimmer ***@***.***> wrote:
*derimmer* left a comment (vasl-developers/vasl#2256)
<#2256 (comment)>
Hi Gordon
I have successfully pulled the changes from
feature/text-info-red-substring into develop. No issues.
However, when I try to pull changes from Gordon into develop, I get two
conflicts, one with release-notes.md. Don't worry about that, I can sort
it. The other is a buildFile conflict. Can you have a look and see if you
can figure out what is going on. It appears that it might be a repeat of
the first PR?
Doug
________________________________
From: GordonMolek ***@***.***>
Sent: Saturday, November 1, 2025 10:51 AM
To: vasl-developers/vasl ***@***.***>
Cc: Doug Rimmer ***@***.***>; Author ***@***.***>
Subject: Re: [vasl-developers/vasl] 671b9 (PR #2256)
[https://avatars.githubusercontent.com/u/102183634?s=20&v=4]GordonMolek
left a comment (vasl-developers/vasl#2256)<
#2256 (comment)>
Yes, please include them or I can do so. I just didn't want to risk
conflicting with anything you were doing.
On Sat, Nov 1, 2025 at 9:14 AM Doug Rimmer ***@***.***> wrote:
> *derimmer* left a comment (vasl-developers/vasl#2256)
> <
#2256 (comment)>
>
> I have created the PR for the final 671 beta, beta9 which I would plan
to
> release on Monday, Nov 3. Aside from Gordon's continued work on counter
> issues, the main changes are to the los code. While there are still bugs
in
> the actual los calculations, this version should enable los in any crop
/
> flip configuration (with los enabled boards).
>
> @GordonMolek <https://github.com/GordonMolek> you still have some
commits
> in your branches that have not been pushed to develop. If you want these
> included, please let me know.
>
> —
> Reply to this email directly, view it on GitHub
> <
#2256 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AYLTFUXOXUEV3UCPK7UIWRD32S53RAVCNFSM6AAAAACK3JY4SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZWGQYDQMBZGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub<
#2256 (comment)>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AB2W6IORWNA47RPFTPYVQ6T32TCH7AVCNFSM6AAAAACK3JY4SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZWGQZTIMRVGM>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub
<#2256 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYLTFUWXLXNH7LJQOB7IP3L32ZNOHAVCNFSM6AAAAACK3JY4SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZYGIZDEMZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
Yes I think so |
Contributor
|
OK, done. Basically all my changes merged with your "beta9" update. I guess
I'll delete the "gordon" branch and start over with a new development
branch.
…On Sun, Nov 2, 2025 at 1:53 PM Doug Rimmer ***@***.***> wrote:
*derimmer* left a comment (vasl-developers/vasl#2256)
<#2256 (comment)>
Doug, Will do. Just to be clear, if I update my both my develop and gordon
local environments I should be able to compare the differences between the
2 branches, right? Gordon
Yes I think so
—
Reply to this email directly, view it on GitHub
<#2256 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYLTFUW4T4LRQHMZNMSV52L32ZHJBAVCNFSM6AAAAACK3JY4SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZYGIZDMOBWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…label-also Allow isMatch to also check the old way.
adding recent commits to 671b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.