automating generation of ssh key pair#187
Open
karthik-vast-ai wants to merge 2 commits intovast-ai:masterfrom
Open
automating generation of ssh key pair#187karthik-vast-ai wants to merge 2 commits intovast-ai:masterfrom
karthik-vast-ai wants to merge 2 commits intovast-ai:masterfrom
Conversation
stackanthony
approved these changes
Apr 4, 2025
skiddar
reviewed
Apr 5, 2025
Contributor
skiddar
left a comment
skiddar
left a comment
There was a problem hiding this comment.
Looks ok, but ssh-keygen may not be installed on all distros.
vast.py
Outdated
| # Generate the key pair if the public key does not exist. | ||
| if not os.path.exists(pub_key_path): | ||
| print("Generating a new RSA SSH key pair...") | ||
| subprocess.run(["ssh-keygen", "-t", "rsa", "-f", key_path, "-q", "-N", ""], check=True) |
Contributor
There was a problem hiding this comment.
Why isn't this in a try catch block?
Contributor
There was a problem hiding this comment.
don't do rsa. We don't need compatibility with 2010
vast.py
Outdated
| print("Unable to add SSH key to the agent. Make sure the ssh-agent is running.") | ||
|
|
||
| # List loaded keys to confirm. | ||
| subprocess.run(["ssh-add", "-l"], check=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.