Fix wrong raw output during vastai attach ssh --raw cmd call#255
Open
borisermakof wants to merge 1 commit intovast-ai:masterfrom
Open
Fix wrong raw output during vastai attach ssh --raw cmd call#255borisermakof wants to merge 1 commit intovast-ai:masterfrom
vastai attach ssh --raw cmd call#255borisermakof wants to merge 1 commit intovast-ai:masterfrom
Conversation
vastai attach ssh key callvastai attach ssh --raw key call
vastai attach ssh --raw key callvastai attach ssh --raw cmd call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks!
This PR fixes two issues:
--rawparameter is used.While working with the vastai CLI, I noticed that my code could not parse JSON when running:
This is because the command returned plain text, which is not useful for programmatic parsing.
Example before the fix:
The output is a string containing a plain text, not valid JSON.
There’s also an extra null line at the end. This forces me to do additional parsing/replacing before I can run
json.loads(output).Example after the fix:
Now the output is valid JSON and can be directly passed to
json.loads()without additional processing.