Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive copy functionality testing to the machine testing process. The changes integrate file transfer tests (local-to-remote and remote-to-local) into the existing machine validation workflow to ensure instances can properly handle file operations.
- Adds proper session management with try/finally cleanup in HTTP requests
- Implements
run_copy_testfunction that creates SSH keys, performs bidirectional file transfers with 100MB test files, and validates transfer integrity - Integrates copy testing into the machine testing workflow with enhanced logging and monitoring
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| def run_copy_test(instance_id, api_key, args): | ||
| """ | ||
| Tests file copy operations between local and remote instance. | ||
|
|
||
| Returns: | ||
| (passed: bool, reason: str) | ||
| """ |
There was a problem hiding this comment.
The PR title contains a spelling error: 'verififcation' should be 'verification'.
| progress_print(args, f"[MACHINE TESTER] Cleaning up instance {instance_id} in finally block") | ||
| destroy_instance_silent(instance_id, destroy_args) | ||
| progress_print(args, f"Machine: {machine_id} Done with testing remote.py results {message}") | ||
| else: | ||
| progress_print(args, f"[MACHINE TESTER] Instance {instance_id} already destroyed or doesn't exist") |
There was a problem hiding this comment.
Inconsistent indentation in the finally block. The lines inside the if statement should be properly indented to match Python standards.
robballantyne
left a comment
robballantyne
left a comment
There was a problem hiding this comment.
Working as intended. Looks good to me @looplater
- Fix rsync protocol: use daemon syntax (::) instead of SSH syntax (:)
- Add correct module name format (C.{instance_id}) for container instances
- Remove redundant --rsh=ssh option (conflicts with -e)
- Remove --rsync-path wrapper that caused protocol mismatch errors
- Remove duplicate self_test__machine function definition that caused argparse conflict
3 participants
No description provided.