Fix SSL state pollution causing self-test failures on Windows (Python 3.13+)#308
Open
begna112 wants to merge 1 commit intovast-ai:masterfrom
Open
Fix SSL state pollution causing self-test failures on Windows (Python 3.13+)#308begna112 wants to merge 1 commit intovast-ai:masterfrom
begna112 wants to merge 1 commit intovast-ai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self-test machinecommand failing withFileNotFoundErroron Windows with Python 3.13+Problem
The
self-test machinecommand was failing with a cryptic error when polling the/progressendpoint:The full traceback showed the error originating from Python's SSL layer during socket reads:
Strangely, the same HTTPS request to the same URL worked fine when executed in a fresh Python process, but failed when run within the
vast.pyscript.Root Cause
SSL context state pollution from earlier API requests to
console.vast.ai(during instance creation and status polling) was corrupting the default connection pool used by therequestslibrary. Whenrun_machinetesterlater tried to poll the test instance's/progressendpoint, the corrupted SSL state caused theFileNotFoundError.Solution
Use a custom
HTTPAdapterthat creates a fresh SSL context for each polling session. This isolates the progress endpoint requests from any state accumulated during earlier API calls:Testing
Tested on Windows 11:
This suggests the issue is related to SSL handling changes introduced in Python 3.13 on Windows.
Test plan