CLI bug fixes, improved help text, and test infrastructure #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes: - Fix mutable default arguments in http_put/post/del - Add missing exception handling in http_request - Fix timezone handling with UTC-aware timestamps - Fix show_instances row rebinding bug - Fix show_machine dict response handling - Fix parse_query field alias data loss - Remove hardcoded if True anti-patterns - Fix raw mode to return parsed JSON consistently - Fix namespace attribute typo - Replace bare except clauses with specific exceptions - Remove shell=True from subprocess calls - Fix self-test instance creation type handling and error messages Infrastructure improvements: - Add request timeout support with configurable defaults - Expand retry logic to cover 502/503/504 and connection errors - Add JSONDecodeError protection to high-risk .json() sites - Consolidate direct requests calls through http_* helpers - Add structured JSON error output for --raw mode - Add raw mode return handling to all command functions - Remove unreachable code after raise_for_status() - Add api_call/output_result/error_output DRY helpers - Add 2FA session expiry handling with automatic key fallback - Filter sensitive fields from show endpoints output CLI improvements: - Improve help text and descriptions for 130+ commands - Add named flags for transfer credit (--sender, --recipient) - Fix argument mismatches in usage strings - Standardize show maints to use --ids instead of -ids - Remove Python 2 compatibility code Test infrastructure: - Add pytest with regression, smoke, and unit test suites - Add CI workflow with lint, test, and smoke-test jobs - Add ruff configuration for code quality - Add dev dependencies to pyproject.toml
This was referenced Feb 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
vast.py
json={}arguments inhttp_put,http_post,http_delResponseobjects instead of parsed JSON in raw modevreferenced already-popped dict keyshow__instances()loop not storing modified rows back to listshow__machine()to handle single dict response (not just list)if True:insearch__benchmarks,search__invoices,search__templatesapi_call(),output_result(),error_output(),require_id()shell=Truefrom SSH/SCP subprocess calls (security)except:clauses with specific exception typesutcfromtimestamp()withfromtimestamp(ts, tz=timezone.utc)Tests (new)
CI (new)
.github/workflows/ci.yml: Ruff lint, pytest across ubuntu/macos/windows x Python 3.9-3.13, standalone smoke testspyproject.toml: Build config, dev dependencies, coverage thresholdsTest plan
python vast.py --helpworkspython vast.py search offers --helpshows improved help textpytest tests/passes (all 547 tests)ruff check vast.pypasses