Skip to content

Fix/sql injection challenge #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbv-18 merged 3 commits into from
Mar 2, 2025
Merged

Fix/sql injection challenge #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
031bcaa
Fix SqlInjectionChallenge with PreparedStatements
vbv-18 Mar 1, 2025
00c9c77
Fix SsqlInjection challenge with Prepared Statements
vbv-18 Mar 1, 2025
4605b6c
Fix SQLInjectionChallenge part 2
vbv-18 Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions src/main/java/org/owasp/webgoat/lessons/sqlinjection/advanced/SqlInjectionChallenge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public SqlInjectionChallenge(LessonDataSource dataSource) {
// assignment path is bounded to class so we use different http method :-)
@ResponseBody
public AttackResult registerNewUser(
@RequestParam String username_reg,
@RequestParam String username_reg, //1 y 2
@RequestParam String email_reg,
@RequestParam String password_reg)
throws Exception {
Expand All @@ -63,25 +63,31 @@ public AttackResult registerNewUser(
if (attackResult == null) {

try (Connection connection = dataSource.getConnection()) {
String checkUserQuery =
"select userid from sql_challenge_users where userid = '" + username_reg + "'";
Statement statement = connection.createStatement();
ResultSet resultSet = statement.executeQuery(checkUserQuery);
String checkUserQuery =
"select userid from sql_challenge_users where userid = ?"; //3,4,5

if (resultSet.next()) {
if (username_reg.contains("tom'")) {
attackResult = success(this).feedback("user.exists").build();
} else {
attackResult = failed(this).feedback("user.exists").feedbackArgs(username_reg).build();
//new secure query
try(PreparedStatement preparedStatement1 = connection.prepareStatement(checkUserQuery)){
preparedStatement1.setString(1, username_reg);

//Statement statement = connection.createStatement();
try(ResultSet resultSet = preparedStatement1.executeQuery()){ //6
if (resultSet.next()) {
if (username_reg.contains("tom'")) {
attackResult = success(this).feedback("user.exists").build();
} else {
attackResult = failed(this).feedback("user.exists").feedbackArgs(username_reg).build();
}
} else {
try(PreparedStatement preparedStatement = connection.prepareStatement("INSERT INTO sql_challenge_users VALUES (?, ?, ?)")){
preparedStatement.setString(1, username_reg);
preparedStatement.setString(2, email_reg);
preparedStatement.setString(3, password_reg);
preparedStatement.execute();
attackResult = success(this).feedback("user.created").feedbackArgs(username_reg).build();
}
}
}
} else {
PreparedStatement preparedStatement =
connection.prepareStatement("INSERT INTO sql_challenge_users VALUES (?, ?, ?)");
preparedStatement.setString(1, username_reg);
preparedStatement.setString(2, email_reg);
preparedStatement.setString(3, password_reg);
preparedStatement.execute();
attackResult = success(this).feedback("user.created").feedbackArgs(username_reg).build();
}
} catch (SQLException e) {
attackResult = failed(this).output("Something went wrong").build();
Expand Down