Fix deploying latest tag deployment #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the deployment workflows for both mainnet and testnet environments to improve reliability and ensure deployment comments are managed correctly. The most important changes include refactoring the checkout process in the mainnet workflow and enhancing the testnet workflow to prevent duplicate deployment comments.
Mainnet workflow improvements:
.github/workflows/mainnet-deploy.ymlby separating the initial repository checkout from the ref selection step, using a manualgit checkoutfor the desired version or tag. This improves clarity and reliability when deploying different versions.Testnet workflow enhancements:
opened,reopened,synchronize) to the workflow configuration in.github/workflows/testnet-deploy.ymlto ensure deployments are triggered on relevant PR events.peter-evans/find-comment, and updated the comment creation step to use the found comment ID. This prevents duplicate deployment comments on pull requests.