-
Notifications
You must be signed in to change notification settings - Fork 3
version: build artifacts version-2.5.1 [iOS] #3732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughBumps release to 2.5.1 across iOS, Android, and package.json; updates changelog with a bug-fix entry for delegation URL protocol casing; and performs an extensive CocoaPods / Xcode project.pbxproj rework affecting pod xcconfig references, build phases, and library/framework entries. Changes
Sequence Diagram(s)(omitted — changes are configuration/version bumps and build-phase rework that do not introduce a new multi-component runtime control flow) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ios/VeWorld.xcodeproj/project.pbxproj (1)
734-927: MARKETING_VERSION still 2.1.3 — should match 2.5.1 release.Line 875 and Line 913 keep
MARKETING_VERSION = 2.1.3;. If Info.plist uses$(MARKETING_VERSION), the app will still ship as 2.1.3 despite the 2.5.1 release. Please update both Debug and Release.🔧 Proposed fix
- MARKETING_VERSION = 2.1.3; + MARKETING_VERSION = 2.5.1;- MARKETING_VERSION = 2.1.3; + MARKETING_VERSION = 2.5.1;
|



This PR was automatically created by the CI pipeline.
Summary by CodeRabbit
Bug Fixes
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.