Skip to content

Conversation

@TheGridExpert
Copy link

@TheGridExpert TheGridExpert commented Aug 27, 2024

Added shapes for each stage of the pies and made them rotate depending on the direction. Same with the feasts, but only for Shepherd's Pie, Honey Glazed Ham and Roast Chicken. I decided not to do this for the Rice Roll Medley because the model would be far too complicated.

8mb.video-OfG-nWsyc3xC.mp4

(Also, AddItemModifier, FDAddTableLootModifier and PastrySlicingModifier were made public in order to allow data generation with them in addon mods)

Copy link
Owner

@vectorwing vectorwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

However, the way this is done on your PR might have significant performance problems. VoxelShapes should not be computed on the fly like this, as joining operations are expensive. It's sort of why I didn't do it originally. 🙁

I asked for some pointers in regards to this on Discord, and it seems this could be executed if these shapes were lazily computed and cached as they're called. In other words, each variant would be calculated once (when needed), then saved to something such as a ConcurrentHashMap, which would be checked later.

If you're willing to try your hand at implementing the feature I mentioned, I can take another look at it. Sorry! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants