Skip to content

Conversation

@rbraunm
Copy link

@rbraunm rbraunm commented Nov 21, 2016

2 steps would be necessary to add support for requiring this class via composer. First, create an account on packagist.com, then update the username in the proposed composer.json (replace rbraunm with your username) file and integrate into the master branch. Then you can upload the package and administrate it.

Alternatively I'll leave the fork and my packagist package unless you request for it to be removed.

@chross
Copy link

chross commented Sep 13, 2023

Any news on this? It seems as if rbraunm did close his repo on github so composer won't work anymore.

@rbraunm
Copy link
Author

rbraunm commented Sep 13, 2023

I did not think anyone would be using it since it hadn't been merged into main yet, but it was relatively easy to set up I think. I don't really remember how now but I can take a look this evening.

Luckily 7 year younger me appears to have given some general instructions I can hopefully follow and the commits are still linked to this PR and so the code is available.

Looking briefly at the code, the composer doc doesn't really include any pre-reqs or anything. Is that a deficiency of the compose document or is it fine as-is and just needs to be put back in my repo/recreated?

@rbraunm
Copy link
Author

rbraunm commented Sep 18, 2023

This was updated and my original composer setup should work properly; I noticed chross has also put his repo up on packagist for use with composer. I will leave this repo alive going forward but feel free to use chross' as well. If the upstream repo ever gets updated or we need to point class_dicom to a new fork, just open an issue on my repo.

@chross
Copy link

chross commented Sep 19, 2023

Hey, my bad for making you do extra work, but when I saw your quick guide on how to release on Packagist, I figured I'd give it a shot. I'd never used Packagist before, but it turned out to be pretty straightforward, and I hope the package will be helpful to others.

@rbraunm
Copy link
Author

rbraunm commented Sep 20, 2023

No worries at all. What I said to myself was: I was too slow! I expected it to be more difficult than it was to remember how it all worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants