Update changes from head repo #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Odoo version 13.0 release 20191009
Without batch option, gpg may try to use /dev/tty. See https://bugs.debian.org/913614
Usage of apt-get should prevent installing wkhtmltopdf on wrong architecture.
In some situations, like when a docker compose file use a data volume to persist postgresql databases, the Odoo server starts and tries to connect to database server before the postgresql server is ready. In such a case, the Odoo containers fails to start. With this commit, the wait-for-it script is used to wait for the database server service to be ready before starting Odoo. This script is available as a Debian package. Closes #258, closes #259
As the wait-for-it script is started before the parsing of the command line, it is always started. It can be a problem if a user wants to start some other binary than odoo (for example a shell). Also, the wait-for-it script is only checking if a port is open on a host and then waits 5 seconds before starting Odoo. With this commit, the wait-for-it script is replaced by a more useful custom python script that checks if the postgresql server is able to handle a connection with the given parameters. Odoo then starts whenever it's ready or fails after a 30 sec timeout.
Small improvement to minimze the number of layers. Thanks to @valerianpereira for the PR. Closes #188
Although the `EXPOSE` instruction does not actually publish the ports, it has an impact on inter docker communication. With this commit, port 8072 is also exposed. Closes #107
Before this commit, the deb package was installed in two steps. The first step was to use dpkg and force the install, the second step was to repair the broken install.
It appears that dash can be unpredictable. Also, uses the `pipefail` as stated in the Dockerfile best practice [1]. [1] https://github.com/docker/docker.github.io/blob/master/develop/develop-images/dockerfile_best-practices.md#using-pipes
When installing postgresql-client, the Debian repo from Postgresql is added as a source list. As a consequence, when installing the Odoo debian packages, the package dependencies are also searched in the Postgresql repo. In this case, it appears that python3-werkzeug version 0.16 was installed from the Postgresql repo. Closes #299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.