Skip to content

Fix modal action icons #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brontes merged 2 commits into from
Nov 11, 2025
Merged

Fix modal action icons #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2594b47
Fix modal action icons
Brontes Nov 11, 2025
c44cf9b
Fix modal action icons - tests
Brontes Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions vue/dynamicforms/src/components/actions/action.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ describe('Action', () => {
expect(action).toHaveProperty('position', 'FORM_FOOTER');
expect(action).toHaveProperty('label', 'Close');
expect(action).toHaveProperty('labelAvailable', true);
expect(action).toHaveProperty('icon', 'close-outline');
expect(action).toHaveProperty('icon', 'ion-close-outline');
expect(action).toHaveProperty('iconAvailable', true);
});

Expand All @@ -148,7 +148,7 @@ describe('Action', () => {
expect(action).toHaveProperty('position', 'FORM_FOOTER');
expect(action).toHaveProperty('label', 'Yes');
expect(action).toHaveProperty('labelAvailable', true);
expect(action).toHaveProperty('icon', 'thumbs-up-outline');
expect(action).toHaveProperty('icon', 'ion-thumbs-up-outline');
expect(action).toHaveProperty('iconAvailable', true);
});

Expand All @@ -161,7 +161,7 @@ describe('Action', () => {
expect(action).toHaveProperty('position', 'FORM_FOOTER');
expect(action).toHaveProperty('label', 'No');
expect(action).toHaveProperty('labelAvailable', true);
expect(action).toHaveProperty('icon', 'thumbs-down-outline');
expect(action).toHaveProperty('icon', 'ion-thumbs-down-outline');
expect(action).toHaveProperty('iconAvailable', true);
});
});
Expand Down
6 changes: 3 additions & 3 deletions vue/dynamicforms/src/components/actions/action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class Action implements ActionJSON {
return new Action({
name: 'close',
label: gettext('Close'),
icon: 'close-outline',
icon: 'ion-close-outline',
displayStyle: { asButton: true, showLabel: true, showIcon: true },
position: 'FORM_FOOTER',
...data, // any properties in data should overwrite properties in the constant
Expand All @@ -159,7 +159,7 @@ class Action implements ActionJSON {
return new Action({
name: 'yes',
label: gettext('Yes'),
icon: 'thumbs-up-outline',
icon: 'ion-thumbs-up-outline',
displayStyle: { asButton: true, showLabel: true, showIcon: true },
position: 'FORM_FOOTER',
...data, // any properties in data should overwrite properties in the constant
Expand All @@ -170,7 +170,7 @@ class Action implements ActionJSON {
return new Action({
name: 'no',
label: gettext('No'),
icon: 'thumbs-down-outline',
icon: 'ion-thumbs-down-outline',
displayStyle: { asButton: true, showLabel: true, showIcon: true },
position: 'FORM_FOOTER',
...data, // any properties in data should overwrite properties in the constant
Expand Down
2 changes: 1 addition & 1 deletion vue/dynamicforms/src/components/table/tcolumn-generic.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function handleClick(event: any) {
callHandler(new Action({
name: 'select',
label: 'Select',
icon: 'thumbs-down-outline',
icon: 'ion-thumbs-down-outline',
position: 'ROW_CLICK',
}));
callHandler(props.actions.rowClick, { column: props.column, event, rowType });
Expand Down
2 changes: 1 addition & 1 deletion vue/dynamicforms/src/components/table/trow-generic.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function handleClick(event: any) {
callHandler(new Action({
name: 'select',
label: 'Select',
icon: 'thumbs-down-outline',
icon: 'ion-thumbs-down-outline',
position: 'ROW_CLICK',
}));
callHandler(props.actions.rowClick, { event, rowType: props.rowType });
Expand Down
Loading