Update app name for html report#1537
Conversation
0765f40 to
8f2888e
Compare
📝 WalkthroughWalkthroughReplaced private Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8f2888e to
f698b2e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
core/src/main/java/org/verapdf/report/HTMLReport.java(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Quality Assurance
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
core/src/main/java/org/verapdf/report/HTMLReport.java (1)
99-106: LGTM!The method logic is correct. It maintains the existing behavior of returning "verapdf-rest" when REST details are present, and now returns "apps" as the default fallback instead of "gui".
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default application identifier used in HTML report generation from "gui" to "apps", providing a more generic fallback name when REST service details are unavailable.
- Changed the constant name from
GUItoAPPS - Updated the string value from "gui" to "apps"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f698b2e to
a3d7766
Compare
a3d7766 to
1159298
Compare
Summary by CodeRabbit