Skip to content

Update app name for html report#1537

Merged
MaximPlusov merged 1 commit intointegrationfrom
html_app_name
Feb 3, 2026
Merged

Update app name for html report#1537
MaximPlusov merged 1 commit intointegrationfrom
html_app_name

Conversation

@MaximPlusov
Copy link
Contributor

@MaximPlusov MaximPlusov commented Jun 30, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Updated how the application label appears in generated reports: when REST details are present the REST identifier is used; otherwise the label now shows "apps" instead of "gui", ensuring consistent and accurate report labeling.

@coderabbitai
Copy link

coderabbitai bot commented Nov 9, 2025

📝 Walkthrough

Walkthrough

Replaced private GUI constant with APPS in HTMLReport. getAppName() still returns VERAPDF_REST when REST details exist; otherwise it returns APPS. No public API or signature changes.

Changes

Cohort / File(s) Summary
Constant rename & logic update
core/src/main/java/org/verapdf/report/HTMLReport.java
Removed GUI = "gui", added APPS = "apps". Updated getAppName() to return APPS when REST details are absent; preserved REST return path (VERAPDF_REST).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 I hopped from GUI to APPS with flair,
A tiny tweak handled with care,
Constants renamed, the logic sings,
Rest stays true while change now springs,
A rabbit's hop — light as air. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the app name constant from 'GUI' to 'APPS' in the HTML report generation class.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch html_app_name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecf7c61 and f698b2e.

📒 Files selected for processing (1)
  • core/src/main/java/org/verapdf/report/HTMLReport.java (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Quality Assurance
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
core/src/main/java/org/verapdf/report/HTMLReport.java (1)

99-106: LGTM!

The method logic is correct. It maintains the existing behavior of returning "verapdf-rest" when REST details are present, and now returns "apps" as the default fallback instead of "gui".

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the default application identifier used in HTML report generation from "gui" to "apps", providing a more generic fallback name when REST service details are unavailable.

  • Changed the constant name from GUI to APPS
  • Updated the string value from "gui" to "apps"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MaximPlusov MaximPlusov merged commit ba747eb into integration Feb 3, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments