Skip to content

Add an automatic module name to the MANIFEST #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximPlusov merged 1 commit into from
Nov 11, 2025
Merged

Add an automatic module name to the MANIFEST #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<parent>
<groupId>org.verapdf</groupId>
<artifactId>verapdf-parent</artifactId>
<version>1.29.1</version>
<version>1.29.6</version>
Copy link

@coderabbitai coderabbitai bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify parent POM version 1.29.6 for compatibility.

The parent version is being bumped from 1.29.1 to 1.29.6. Confirm this version exists and review the changelog to ensure there are no breaking changes or dependency conflicts.

🏁 Script executed:

#!/bin/bash
# Description: Verify parent POM version 1.29.6 exists and retrieve details.

# Search for the parent POM in Maven Central and check if version exists
curl -s "https://repo.maven.apache.org/maven2/org/verapdf/verapdf-parent/1.29.6/verapdf-parent-1.29.6.pom" -o /dev/null -w "HTTP Status: %{http_code}\n"

Length of output: 16


---

🏁 Script executed:

```shell
#!/bin/bash
# Description: Check available versions of verapdf-parent in Maven Central

# List available versions by querying Maven Central metadata
curl -s "https://repo.maven.apache.org/maven2/org/verapdf/verapdf-parent/maven-metadata.xml" | grep -oP '(?<=<version>)[^<]+'

Length of output: 128

Critical: Parent POM version 1.29.6 does not exist in Maven Central Repository.

The parent version specified (1.29.6) is unavailable in Maven Central. Available versions of verapdf-parent only extend to 1.28.2. The build will fail unless this is resolved. Either:

  • Verify the version number is correct for your repository configuration
  • Use an available version (latest is 1.28.2)
  • Confirm a custom/private repository contains 1.29.6
🤖 Prompt for AI Agents 
In pom.xml around line 30, the parent POM version is set to 1.29.6 which does
not exist in Maven Central; update the parent version to an available release
(for example 1.28.2) or change/add your repository configuration that hosts
1.29.6. Edit the <version> value to a published version or add the
custom/private repository entry where 1.29.6 is hosted and re-run mvn validate
to ensure Maven can resolve the parent POM.

<relativePath />
</parent>

Expand Down Expand Up @@ -75,6 +75,17 @@

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>org.verapdf.pdf.model</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
Expand Down