Add main attribute owners to ASAtom

[LonelyMidoriya]

Summary by CodeRabbit

• New Features
  • Expanded document processing capabilities with support for Layout, List, and Table structural elements, enabling improved handling of complex document compositions.

[coderabbitai]

📝 Walkthrough

Walkthrough

Three new public static final ASAtom constants (LAYOUT, LIST, and TABLE) were added to the ASAtom class in their respective alphabetically-organized sections, expanding the predefined set of atom name identifiers without modifying existing logic.

Changes

Cohort / File(s)	Summary
ASAtom Constants src/main/java/org/verapdf/as/ASAtom.java	Added three new public static final ASAtom constants: LAYOUT, LIST, and TABLE with their respective string representations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Add list numbering types to ASAtom #692: Adds new public static final ASAtom constants to the same class file — directly related expansion of atom definitions.
• Add ContinuedFrom and ContinuedList to ASAtom #691: Modifies the same ASAtom class by adding new public static final constants — similar pattern of constant augmentation.

Suggested reviewers

• MaximPlusov

Poem

🐰 Three new atoms join the fold,
Layout, List, and Table bold,
Constants gleaming, bright and clean,
The finest set I've ever seen! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Add main attribute owners to ASAtom' is vague and does not clearly reflect the specific changes made (addition of three new constants: LAYOUT, LIST, and TABLE).	Consider using a more specific title such as 'Add LAYOUT, LIST, and TABLE constants to ASAtom' or 'Add structural attribute constants to ASAtom' to better describe the concrete changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch attribute-owners

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/main/java/org/verapdf/as/ASAtom.java (1)

355-355: Consider adding PrintField for completeness of standard attribute owners.

ISO 32000-2 (Table 378) lists five standard structure attribute owners: Layout, List, Table, PrintField, and Artifact. Artifact is already present (line 79), and this PR adds the other three — but PrintField remains absent. If these constants are being added to support attribute-owner lookups in tagged-PDF validation, omitting PrintField may require a follow-up PR.

➕ Suggested addition in the P section (after `PRINT_SCALING`, line 480)

     public static final ASAtom PRINT_SCALING = new ASAtom("PrintScaling");
+    public static final ASAtom PRINT_FIELD = new ASAtom("PrintField");
     public static final ASAtom PROC_SET = new ASAtom("ProcSet");

Also applies to: 366-366, 573-573

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/main/java/org/verapdf/as/ASAtom.java` at line 355, The file is missing
the standard attribute-owner constant for "PrintField"; add a new public static
final ASAtom PRINTFIELD = new ASAtom("PrintField") to ASAtom so all ISO 32000-2
standard owners are present; place the constant in the P section (e.g., after
the existing PRINT_SCALING entry) and ensure the identifier is PRINTFIELD and
the string literal is exactly "PrintField" to match the other ASAtom constants
(refer to existing constants like LAYOUT, LIST, TABLE, ARTIFACT for placement
and naming style).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/main/java/org/verapdf/as/ASAtom.java`:
- Line 355: The file is missing the standard attribute-owner constant for
"PrintField"; add a new public static final ASAtom PRINTFIELD = new
ASAtom("PrintField") to ASAtom so all ISO 32000-2 standard owners are present;
place the constant in the P section (e.g., after the existing PRINT_SCALING
entry) and ensure the identifier is PRINTFIELD and the string literal is exactly
"PrintField" to match the other ASAtom constants (refer to existing constants
like LAYOUT, LIST, TABLE, ARTIFACT for placement and naming style).