Example of diamonds for DID resolution#22
Open
Hmac512 wants to merge 9 commits intoveramolabs:mainfrom
Open
Conversation
Author
Author
|
The idea I am getting at is we can actually give each resolver direct access to the document storage to create/update DID Documents. The following code is where the magic happens: In this code the resolver itself is handling the idProxyAddress, which determines the pointer for the document map. We can utilize the pattern here instead: So the entry point to each resolver is through a function in DID.sol. There the address for the pointer is determined based on the intended resolver. Then our document storage can do something like this to get the pointer, and send it to the resolver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple stupid example of how to set up replaceable resolvers with the Diamond pattern.
The tests were written really fucking quickly, and the code for the tests isn't pretty. Might be a good exercise for someone to go through and write full coverage tests.
There is nothing to do with DIDs in this implementation, it’s more like a NFT contract. All in due time.