Skip to content

fix: prevent duplicate edges between same nodes #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasir-ali9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent duplicate edges between same nodes #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 31 additions & 10 deletions components/workflow/workflow-canvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,17 @@ export function WorkflowCanvas() {

const onConnect: OnConnect = useCallback(
(connection: XYFlowConnection) => {
// Check if an edge already exists between these nodes
const existingEdge = edges.find(
(edge) =>
edge.source === connection.source && edge.target === connection.target
);

// Prevent duplicate edges between the same nodes
if (existingEdge) {
return;
}

const newEdge = {
id: nanoid(),
...connection,
Expand Down Expand Up @@ -416,17 +427,27 @@ export function WorkflowCanvas() {

// Create connection from the source node to the new node
const fromSource = connectingHandleType.current === "source";
const sourceId = fromSource ? sourceNodeId : newNode.id;
const targetId = fromSource ? newNode.id : sourceNodeId;

const newEdge = {
id: nanoid(),
source: fromSource ? sourceNodeId : newNode.id,
target: fromSource ? newNode.id : sourceNodeId,
type: "animated",
};
setEdges([...edges, newEdge]);
setHasUnsavedChanges(true);
// Trigger immediate autosave for the new edge
triggerAutosave({ immediate: true });
// Check if an edge already exists between these nodes
const existingEdge = edges.find(
(edge) => edge.source === sourceId && edge.target === targetId
);

// Only create edge if it doesn't already exist
if (!existingEdge) {
const newEdge = {
id: nanoid(),
source: sourceId,
target: targetId,
type: "animated",
};
setEdges([...edges, newEdge]);
setHasUnsavedChanges(true);
// Trigger immediate autosave for the new edge
triggerAutosave({ immediate: true });
}

// Set flag to prevent immediate deselection
justCreatedNodeFromConnection.current = true;
Expand Down