Conversation
PR: Fixed indexing issue in the _channel_spatial_filter() which led to array setting error.
for more information, see https://pre-commit.ci
Owner
|
Hey @KishiBayes, thanks for opening this PR. Could you provide a bit more details about the issue you encountered, and what this code change wants to achieve ? From what I understand, there can be an issue in the current code version: where several neighbors can have a min/mask value and therefore removing more than 2 neighboring values, resulting in an error. Is that it ? I may be wrong, please don't hesitate to let me know if it is the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fixed indexing issue in the _channel_spatial_filter() which led to array setting error.
Issue was only occurring on some files, which were loaded from fifs, converted from edf imports. Now runs smoothly.