Add support for ERP analysis: ignore_polarity = False#93
Draft
Add support for ERP analysis: ignore_polarity = False#93
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 90.00% 96.33% +6.32%
==========================================
Files 33 54 +21
Lines 2892 4121 +1229
Branches 678 0 -678
==========================================
+ Hits 2603 3970 +1367
+ Misses 172 151 -21
+ Partials 117 0 -117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
|
Adding one more bullet point:
|
a3e5c12 to
fb3be39
Compare
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160
As discussed in #92, we could add support for taking into account polarities in the analysis.
Here is a list of changes that need to be implemented:
self._ignore_polarity(bool) attribute to_BaseCluster. This attribute can only be changed using theignore_polarityargument of the.fit()method ( to be added).By default during fitting,
ignore_polarityshould be set to True forRaw,Epochs,ChDataandFalseforEvoked..predictshould have the same behaviour as.fit(): it should useself._ignore_polarity.ignore_polarityvalue used during prediction should be store in segmentations_BaseCluster.invert_polarityshould not work whenself._ignore_polarityis set toFalse.metricsshould take into accountcluster._ignore_polarity.Feel free to complete this list