Skip to content

allow checking oversized snarls #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faithokamoto merged 1 commit into from
Jan 16, 2026
Merged

allow checking oversized snarls #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bdsg/src/snarl_distance_index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,20 +244,20 @@ if(get_handle_type(net) == SNARL_HANDLE){
if ((record_type == SNARL || record_type == OVERSIZED_SNARL) && graph == nullptr) {
throw runtime_error("error: is_regular_snarl requires a graph if the distance index doesn't contain distances");
}
if ((record_type == SNARL || record_type == OVERSIZED_SNARL) && !allow_internal_loops) {
if (record_type == SNARL && !allow_internal_loops) {
throw runtime_error("error: is_regular_snarl requires distances in the distance index to verify that there are no internal loops");
}

//If there is any edge from the boundary nodes to themselves, then it cannot be regular
// How we check this depends on if we have distances or not
net_handle_t start_in = get_bound(net, false, true);
net_handle_t end_in = get_bound(net, true, true);
if (record_type == DISTANCED_SNARL) {
if (record_type == DISTANCED_SNARL || record_type == OVERSIZED_SNARL) {
if (has_edge(start_in, start_in) ||
has_edge(end_in, end_in)) {
return false;
}
} else if (record_type != DISTANCED_SNARL) {
} else if (record_type != DISTANCED_SNARL && record_type != OVERSIZED_SNARL) {
if (graph->has_edge( get_handle(flip(start_in), graph), get_handle(flip(start_in), graph)) ||
graph->has_edge( get_handle(flip(end_in), graph), get_handle(flip(end_in), graph))) {
return false;
Expand Down