Fix the double users showing in results #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 29, 2025 17:13
robmackenzie
changed the title
EricNelson12
approved these changes
Jul 30, 2025
EricNelson12
left a comment
EricNelson12
left a comment
There was a problem hiding this comment.
One question, but otherwise lgtm!
| # Need to do a quick simple de-dupe due to a bug in the pagination from Discourse | ||
| deduped_list=[] | ||
| for user in results: | ||
| if user not in deduped_list: |
There was a problem hiding this comment.
what is the type of user? if it's a reference to a class or dict or something then the user not in deduped_list might not work as it appears to if the same user has had two difference instances made. BUT I'm assuming it's a string with their username, in which case this should be good 😄
There was a problem hiding this comment.
And if they are just strings, then can we go list(set(users)) to de-dup?
Contributor
Author
There was a problem hiding this comment.
User is a dict. results is a list of those dicts.
NB: we discussed this in slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.