Fix error when trying to override concurrency option via CLI option#1
Fix error when trying to override concurrency option via CLI option#1vicary merged 3 commits intovicary:serialized-compilefrom coyoteecd:serialized-compile
Conversation
… serverless.yml. Left only number conversion, since CLI options are typed as string
|
@coyoteecd Thanks for the effort! I'll rebase from upstream from time to time. My first attempts got errors on tests about |
|
@vicary Do you plan to submit a PR to the main repo with your (and my) changes in this fork? I am using these changes in a project and do not want to fall behind the upstream. |
|
@coyoteecd I am 50/50 about submitting PR in this state, because when I rebase from upstream, the conflict is huge. I guess we'll have to at least successfully rebase once before a PR, what do you think? |
|
Yeah you'd need to rebase first. If you don't want/have time to do it, I can take the code and submit a PR myself; end goal is to get these changes in the main serverless-webpack repo. |
|
Weirdly enough, upstream master has missing commits when compared with the fork by takeshape. Not sure if it was squashed in a PR or something, this rebase was not easy. Hopefully they'll take this seriously serverless-heaven#680, for the sake of disambiguation the rebased branch is now |
The concurrency option has an issue when being overridden via CLI, namely it is passed as a string.
Bluebird does not like it and throws the following error:
Fixed this by adding a Number conversion for it in compile.js. This means one can use it as this:
and then override it as any other serverless option:
serverless package --compile-concurrency 3