Added support for http_client,extra_headers and extra_query in openai#23
Open
daichi-m wants to merge 1 commit intovictordibia:mainfrom
Open
Added support for http_client,extra_headers and extra_query in openai#23daichi-m wants to merge 1 commit intovictordibia:mainfrom
daichi-m wants to merge 1 commit intovictordibia:mainfrom
Conversation
Author
|
@victordibia Can this be reviewed and merged? |
Author
|
@victordibia Can we move forward with this? |
|
@victordibia Can we merge these changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes to support custom HTTP client, default headers and default queries in using OpenAITextGenerator.
Why is this change required
We want to pass custom headers to our internal proxy layer which is built on top of AzureOpenAI for our internal audit and metrics. Currently this is not supported on llmx and subsequently, not available via lida. This change attempts to add support for a custom http_client along with additional default_headers and default_query parameters.
How is this tested
We have done an internal testing with our proxy layer. Sample code: