chore: vhs utils update #1036
Merged
chore: vhs utils update #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
chore/vhs-utils-update
branch
from
d98d10b to
b7e4478
Compare
brandonocasey
changed the base branch from
chore/better-worker-build
to
main
gkatsev
previously approved these changes
Dec 16, 2020
Member
gkatsev
left a comment
gkatsev
left a comment
There was a problem hiding this comment.
Works well, just needs to wait for the vhs-utils update.
gesinger
reviewed
Jan 5, 2021
gkatsev
previously approved these changes
Jan 11, 2021
Member
gkatsev
left a comment
gkatsev
left a comment
There was a problem hiding this comment.
Did a test and it's working. Confirmed that with this change we will properly pick up missing codecs and be able to play them even if they are partially missing from the manifest.
brandonocasey
force-pushed
the
chore/vhs-utils-update
branch
from
c5b8dc5 to
2d752cf
Compare
gkatsev
previously approved these changes
Jan 11, 2021
gesinger
previously approved these changes
Jan 11, 2021
brandonocasey
commented
Jan 12, 2021
| }); | ||
|
|
||
| QUnit.test('does not blacklist incompatible codecs with codec switching', function(assert) { | ||
| const oldIsTypeSupported = window.MediaSource.isTypeSupported; |
Contributor
Author
There was a problem hiding this comment.
edge support ac-3, we need to mock that it doesn't support it for this test.
brandonocasey
commented
Jan 12, 2021
| } | ||
|
|
||
| if (blacklistReasons.length) { | ||
| variant.excludeUntil = Infinity; |
Contributor
Author
There was a problem hiding this comment.
moved the exclude down here so we don't do it in every if.
brandonocasey
commented
Jan 12, 2021
| const videoDetails = codecs.video && parseCodecs(codecs.video)[0] || null; | ||
| const audioDetails = codecs.audio && parseCodecs(codecs.audio)[0] || null; | ||
|
|
||
| Object.keys(playlists).forEach((key) => { |
Contributor
Author
There was a problem hiding this comment.
loop through all playlists for sure
brandonocasey
commented
Jan 12, 2021
| }); | ||
|
|
||
| QUnit.test('blacklists ts playlists by muxer support', function(assert) { | ||
| const oldIsTypeSupported = window.MediaSource.isTypeSupported; |
Contributor
Author
There was a problem hiding this comment.
again with browser codec support needing to be overridden.
gesinger
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the following:
videojs/aes-decrypter#81videojs/m3u8-parser#118videojs/mpd-parser#115