Made rectangle parameter optional & automatically calculate width/height.#1
Open
xLite wants to merge 4 commits intovillekoskelaorg:masterfrom
Open
Made rectangle parameter optional & automatically calculate width/height.#1xLite wants to merge 4 commits intovillekoskelaorg:masterfrom
xLite wants to merge 4 commits intovillekoskelaorg:masterfrom
Conversation
You check to see if rectangle is null in the function so I'm guessing you forgot to set the parameter's default value to null. Fixed.
Removes the need to manually specify the width and height. Simply set the absolute maximum width and height (like 2048x2048 if you're working with a Stage3D texture) and the class will automatically calculate the smallest possible width and height after packing. Accessible via the `width` and `height` getters.
|
`` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You check to see if
rectangleisnullingetRectangle()so I'm guessing you forgot to set the parameter's default value tonull. Fixed.Also added the feature to make it so that, after packing, you can access special
widthandheightgetters that retrieve the smallest possible values in order to house every single rectangle. Useful if you need to know what size to set a texture/RenderTextureobject in Starling.