Skip to content

Conversation

@AldaronLau
Copy link
Contributor

@vinc
Copy link
Owner

vinc commented Mar 8, 2022

Thanks for your contribution, I'll have a look to see if 0.3 is compatible with the no_std version of the crate, I know that's not the case for MOROS, an OS I'm writing (vinc/moros#273), and this might complicate integrating geodate inside MOROS (vinc/moros#304). There's also a refactor of this crate going on here: #37

But in any case we can go from 0.1 to 0.2 that's for sure.

.gitignore Outdated
@@ -1 +1,2 @@
target
Cargo.lock
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crate is both a library and an application so I decided to check in Cargo.lock due to the latter, see: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the change to Cargo.lock and .gitignore

@AldaronLau
Copy link
Contributor Author

Since am I coincidentally also involved in an OS project, I know what that error is and how to fix it. It's missing compiler intrinsics for your OS, which you can fix by forking the compiler intrinsics crate:

https://github.com/ardaku/compiler-builtins/tree/quantii

This fork adds intrinsics support for ARM and RISC-V for the OS, feel free to steal any of it.

Here's a link to what kind of patches might be necessary:

ardaku/compiler-builtins@2bda4a4#diff-e3c4de8cd9ff6e9b0f9ac58475dfdd0b02ddad8b0f28bfe08b5aa5ee276c39baR107-R120

@AldaronLau
Copy link
Contributor Author

I'll also add that this is how we link it to our OS: https://github.com/ardaku/quantii/blob/main/Cargo.toml#L17

And that you have to rename the compiler-builtins crate: https://github.com/ardaku/compiler-builtins/blob/quantii/Cargo.toml#L3

Copy link
Owner

@vinc vinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vinc vinc merged commit 0451843 into vinc:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants