Adding support for External Account Binding #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mania Kazemzadeh <mania@substruct.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that adds External Account Binding support to Certificator, which in turn adds support for ZeroSSL.
Unfortunately adding a test for this necessitated a new instance of pebble (
pebble-eab) with EAB enabled, and a new certificate which haspebble-eabas a SAN (the default only supportspebbleandlocalhost). This has been signed against the CA provided in the Pebble repository and copied tofixtures/in certificator.As per #9, this is work done for a client that I'm now offering upstream 🙂