feat: add TypeScript definitions for byte utility #68
+186
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve TypeScript type definitions for better type safety
What's the issue?
I've been using this library in my project and noticed that TypeScript doesn't catch invalid byte strings at compile time. For example:
This can lead to bugs that could've been caught during development. The library works fine and returns
nullfor invalid inputs, but it'd be nice to get feedback from TypeScript earlier.What changed?
I refactored the
BytesStringtype to be cleaner and more maintainable. The old definition had a lot of repetition:I broke it down into helper types:
Also added a fallback
stringoverload so dynamic strings (like user input) still work without TypeScript errors.Why this matters
For literal strings (known at compile time):
For dynamic strings (runtime values):
Better DX:
Backwards compatibility
Everything that worked before still works. I tested with: