fix: use build.client output directory for adapters

[hugo-vrijswijk]

For server outputs, the dist/client output directory should be used and not dist.

[userquin]

what's the issue?

[hugo-vrijswijk]

On any configuration, all pwa-assets will be output to dist/ instead of dist/client/ for server output. For static sites, this is what you want, but for server output the files will not be found (Astro will only look in dist/client for static assets on server output)

[hugo-vrijswijk]

Ok slightly different. The detection should be if config.adapter is used, not config.output. Since you can use an adapter with static output. But if an adapter is used, the outDir should be dist/client

[userquin]

Looks like we also have adapters in Astro ;)

Can you send a new PR with an SSR minimal example (or just include it here) 🙏?

EDIT: I need some time to read the Astro docs

[hugo-vrijswijk]

I'll add a SSR example

[hugo-vrijswijk]

@userquin I've pushed a SSR example. It's mostly the same code as examples/pwa-simple-assets-generator. But the asset generation is needed to show the bug.

[pkg-pr-new]

npm i https://pkg.pr.new/@vite-pwa/astro@64

commit: d321f2b

[userquin]

The example will not work when going offline, the sw requires the navigate fallback (offline support) and since we're not prerendering (SSG for at least 1 route => the offline page) any route will fail, but the example is fine.

With any SSR (meta-)framework we have previous problem, I need to think the best solution for this to solve the problem in all integrations, for context:

• Navigating to SvelteKit error page after a new build causes infinite page reload loop sveltekit#65
• feat: add SSR workbox support nuxt#66

Looks like we can prerender routes: https://github.com/withastro/astro/blob/3b10b97a4fecd1dfd959b160a07b5b8427fe40a7/packages/astro/src/types/public/integrations.ts#L26

[userquin]

@hugo-vrijswijk added prerendering index route and added small runtime caching to cache SSR pages (will use always NetworkFirst strategy), this way if the client navigates the application and goes offline, the cache will allow navigate precached routes (visited), otherwise error.

EDIT: looks like Astro won't have solution for this since there is no runtime in the client (client router) like Nuxt or SvelteKit.

[userquin]

thx ❤️

[hugo-vrijswijk]

@userquin can this be merged? Or does it need more changes?

[userquin]

Yes, I'll merge and release a patch version in the afternoon, I was asking Astro people (Nate) about partial SSR support (there is no client-side runtime).

Did you check the changes in the example?