Draft
Conversation
Member
Author
|
Arrg, something is broken, if we add webmanifest at globPatterns when using Env. API it is added, but running it without Env. API webmanifest added twice, something is running with wrong configuration when enabling Env. API. Looks like this if stmt. breaking webmanifest here: https://github.com/vite-pwa/vite-plugin-pwa/pull/786/files#diff-001347cc727cf0cda0ccc53a07a92207e342ab83fe88aaa789b752a9e9ea5832R61-R62 Previous function being called from main PWA plugin, it is shared between environments (?) but SSR being used 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now the webmanifest not being added to the sw precache manifest (and not being generated using
nr dev:build), tried with a client plugin (it seems the folder being cleared => node_modules/.cache/nuxt/.nuxt/manifests), also with rollup:before => there is no way.We need to know "when" we can build the webmanifest.
Using PWA plugin from pkg-pr-new from this PR vite-pwa/vite-plugin-pwa#903
Linked Issues
Additional Context
We should add to Nuxt docs we only have a single dev server for both environments, I also need to check with generate command (maybe it is also broken here).
Playing with Vite Env. API and
future.compatibility = 5seems to break Nuxt Dev Tools when there is no layout; vite-rolldown also broken with Vite Env. API (with empty project, some Vite plugin breaking Nuxt)Tip
The author of this PR can publish a preview release by commenting
/publishbelow.