Fix warning from clang on testing function return.#28
Open
scott-snyder wants to merge 1 commit intovitillo:masterfrom
Open
Fix warning from clang on testing function return.#28scott-snyder wants to merge 1 commit intovitillo:masterfrom
scott-snyder wants to merge 1 commit intovitillo:masterfrom
Conversation
m_socket->send() returns a bool, but code in ServerSocket.cpp compares it against -1. clang16 generates a warning that this comparision is never true. Apparently this is written this way because the library used to return an int here, but now signals errors by raising an exception. Avoid the warning by casting to an int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_socket->send() returns a bool, but code in ServerSocket.cpp compares it against -1. clang16 generates a warning that this comparision is never true.
Apparently this is written this way because the library used to return an int here, but now signals errors by raising an exception. Avoid the warning by casting to an int.