Rename timing helper functions #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ms to cycles_to_millis
|
|
Contributor
|
build_prs #189 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/19752362119. |
lawkai-vivo
requested changes
Nov 28, 2025
| @@ -0,0 +1,98 @@ | |||
| # This file is automatically @generated by Cargo. | |||
Contributor
There was a problem hiding this comment.
We are not using cargo to build our project, please check https://vivoblueos.github.io/book to getting started.
| } | ||
|
|
||
| pub(crate) fn get_cycles_to_duration(cycles: u64) -> core::time::Duration { | ||
| pub(crate) fn cycles_to_duration(cycles: u64) -> core::time::Duration { |
Contributor
There was a problem hiding this comment.
Are there any code calling these functions?
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/19752362119. |
lawkai-vivo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR rename timing helpers, commited changes:
get_cycles_to_duration -> cycles_to_duration
get_cycles_to_ms _> get_cycles_to_ms
Fixes #179