Fix: librs oops should report location info #292
Conversation
|
build_prs #292 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/21052449942. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/21052449942. |
lawkai-vivo
left a comment
lawkai-vivo
left a comment
There was a problem hiding this comment.
Semihosting should not enabled when we're not testing.
| #[cfg(not(feature = "std"))] | ||
| #[panic_handler] | ||
| fn oops(info: &core::panic::PanicInfo) -> ! { | ||
| #[cfg(test)] |
There was a problem hiding this comment.
Try using #[cfg(debug)] at present.
There was a problem hiding this comment.
if not semihosting, what crate/method rsrt could use now? just need an print, #[cfg(debug)] not work
There was a problem hiding this comment.
It should work under debug mode.
There was a problem hiding this comment.
It should work under debug mode.
Ok, my fault. The cfg has been mistakenly removed. Please update https://github.com/vivoblueos/build/blob/3939793f48f6b39c95434c0bc73d4cf405f02e10/config/BUILD.gn#L20 by adding --cfg ${build_type}.
zhanghe-vivo
force-pushed
the
zhanghe_fix_oops
branch
from
cd8e3a2 to
d04027e
Compare
|
build_prs #292 vivoblueos/build#51 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/21061876528. |
|
❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/21061876528. |
|
build_prs #292 vivoblueos/build#51 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/21062574404. |
|
❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/21062574404. |
zhanghe-vivo
force-pushed
the
zhanghe_fix_oops
branch
from
d04027e to
395f70b
Compare
|
build_prs #292 vivoblueos/build#51 |
|
Job is started, see https://github.com/vivoblueos/kernel/actions/runs/21170691643. |
|
✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/21170691643. |
zhanghe-vivo
force-pushed
the
zhanghe_fix_oops
branch
from
395f70b to
b354b56
Compare
2 participants
No description provided.