Open
Conversation
Collaborator
|
Thanks for the contribution @albertoperdomo2! Sorry on the delay, we just had a very large refactor that's been in the works for awhile land. Could you go through and update to work on top of that? I can also take a look at migrating this a bit later if that's too big of an ask from your side |
Author
|
@markurtz sure thing, I'll update my PR with the latest changes and ping you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new rate type
stepsto the suite of benchmarks. This new rate type allows the user to use--steps-durationto set a comma separated list of step duration values in seconds, and--steps-rateto set a comma separated list of rate values. This simulates, as the name implies, rate steps along time.Details
--steps-duration,--steps-rate.StepsProfileclass.AsyncStepsStrategyscheduler strategy that handles the logic and includes the optional initial burst.create_profilefunction to handle the new arguments.Test Plan
Related Issues
Use of AI
## WRITTEN BY AI ##)