feat: Add TIFF support to document and image generate routes#151
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: Add TIFF support to document and image generate routes#151devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Add tiff.py utility for extracting pages from multi-page TIFF files - Add .tif to SUPPORTED_IMAGE_FILETYPES - Add .tif and .tiff to SUPPORTED_DOCUMENT_FILETYPES - Update CLI generate.py to handle multi-page TIFFs in both image and document commands - Update version to 0.17.18 Co-Authored-By: dinesh@vlm.run <dinesh@vlm.run>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for TIFF files (including multi-page TIFFs) to both the
imageanddocumentgenerate CLI commands. Multi-page TIFFs are handled similarly to PDFs - each page/frame is extracted and passed as separate images to the API.Changes:
vlmrun/common/tiff.pyutility for extracting pages from multi-page TIFF files using PIL.tiftoSUPPORTED_IMAGE_FILETYPESand both.tif/.tifftoSUPPORTED_DOCUMENT_FILETYPESgenerate imagecommand to handle multi-page TIFFsgenerate documentcommand to convert TIFFs to images and route throughimage.generate()instead ofdocument.generate()Review & Testing Checklist for Human
imageanddocumentcommandsdocumentcommand are routed throughclient.image.generate()rather thanclient.document.generate(). Confirm this is the expected behavior.Suggested test plan:
Notes
chat.pychanges are just formatting fixes from black, not functional changes