Backend for delete functionality#117
Conversation
5bdaeae to
1a9fa67
Compare
54f9943 to
adc2e9d
Compare
32db801 to
366ebf0
Compare
5cddc9f to
bbfc5ed
Compare
|
i am not getting this error @JesseStutler , but i modified error handling part, can u check it once more?? |
ab1050b to
6472e41
Compare
Screen.Recording.2025-05-21.223457.mp4 |
|
Sorry my previous mistake, I think we still need to wrap the error message returned from the kube-apiserver, directly return the whole body is not enough, like this pic: |
|
@Shrutim1505 BTW, please clean your commit message: |
6472e41 to
5d6062e
Compare
5d6062e to
51e2287
Compare
b8db733 to
5c1881c
Compare
| `Failed to delete queue (${response.status})`, | ||
| ); | ||
| } else { | ||
| switch (response.status) { |
There was a problem hiding this comment.
However, the current approach can be a bit verbose and hard to maintain as the app scales.
backend/src/server.js
Outdated
| } catch (err) { | ||
| const statusCode = err?.statusCode || err?.response?.statusCode; | ||
|
|
||
| if (statusCode === 404) { |
7fe0470 to
c9f5c99
Compare
|
@JesseStutler @Monokaix please check it |
|
|
ef6d1af to
24c7c25
Compare
|
Now it's OK, please clean your commit message, thanks |
24c7c25 to
8f69723
Compare
Signed-off-by: Shrutim1505 <shrutimurthy2103@gmail.com>
8f69723 to
31c5d7c
Compare
|
@JesseStutler please check |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |






Description:
This PR introduces the backend implementation for the delete functionality. It includes the necessary route, controller logic, and service integration to handle delete operations securely and efficiently.
Changes Made:
Added DELETE API endpoint in the backend
Implemented controller and service logic for delete operation
Integrated appropriate validations and error handling
Updated documentation (if applicable)
Testing:
Verified delete functionality with valid and invalid inputs
Ensured proper status codes and messages are returned
Confirmed no unintended side effects on other endpoints